Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fix links to kak decomposition demo #6784

Merged
merged 8 commits into from
Jan 10, 2025
Merged

[docs] fix links to kak decomposition demo #6784

merged 8 commits into from
Jan 10, 2025

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Jan 8, 2025

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Qottmann Qottmann marked this pull request as draft January 8, 2025 09:57
@Qottmann Qottmann added this to the v0.40 milestone Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v0.40.0-docs@0ab9d24). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff               @@
##             v0.40.0-docs    #6784   +/-   ##
===============================================
  Coverage                ?   99.60%           
===============================================
  Files                   ?      476           
  Lines                   ?    45232           
  Branches                ?        0           
===============================================
  Hits                    ?    45055           
  Misses                  ?      177           
  Partials                ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qottmann
Copy link
Contributor Author

For as long as the objects.inv file is not updated I would proceed with this hot fix that uses static links - for the moment as long as the :doc: links to the new demos continue to not work

PietropaoloFrisoni
PietropaoloFrisoni approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you pull from the docs branch, there should be an automatic sphinx check. If that is fine this is good to go for me!

@Qottmann Qottmann marked this pull request as ready for review January 10, 2025 16:39
@Qottmann Qottmann enabled auto-merge (squash) January 10, 2025 16:39
@Qottmann Qottmann merged commit 5256384 into v0.40.0-docs Jan 10, 2025
16 checks passed
@Qottmann Qottmann deleted the fixkaklinks branch January 10, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietropaoloFrisoni PietropaoloFrisoni PietropaoloFrisoni approved these changes

@dwierichs dwierichs dwierichs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.
3 participants
@Qottmann @dwierichs @PietropaoloFrisoni